Skip to content

Conversation

@hellohellenmao
Copy link
Contributor

@hellohellenmao hellohellenmao commented Jan 20, 2026

production changed the default of -inode-file-handles from never to prefer, so to have the previous behavior you need to pass --inode-file-handle=never

ID: 4839

Summary by CodeRabbit

  • Tests
    • Updated test configuration for a virtual filesystem capability variant to add an extra runtime option that disables inode file handles for that specific case, improving how the scenario is exercised.

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai
Copy link

coderabbitai bot commented Jan 20, 2026

Walkthrough

A single configuration line is added to qemu/tests/cfg/virtio_fs_set_capability.cfg within the with_cache.auto variant under the cap_dac_read_search capability. The new entry adds fs_binary_extra_options with the value inode-file-handles=never to the virtiofsd binary options for this specific test configuration path.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely summarizes the main change: adding a specific command-line option (--inode-file-handle=never) to the virtio_fs_set_capability configuration.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Fix all issues with AI agents
In `@qemu/tests/cfg/virtio_fs_set_capability.cfg`:
- Line 90: Update the virtiofsd option string appended to
fs_binary_extra_options: replace the incorrect singular flag
"--inode-file-handle=never" with the correct plural "--inode-file-handles=never"
so the fs_binary_extra_options concatenation uses the proper virtiofsd option
name.

production changed the default of -inode-file-handles
from never to prefer, so to have the previous behavior
you need to pass --inode-file-handle=never

Signed-off-by: Tingting Mao <[email protected]>
@hellohellenmao
Copy link
Contributor Author

(1/1) Host_RHEL.m10.u2.ovmf.qcow2.virtio_blk.up.virtio_net.Guest.RHEL.9.7.0.x86_64.io-github-autotest-qemu.virtio_fs_set_capability.remove_capability.cap_dac_read_search.with_cache.auto.q35: PASS (100.52 s)

@fbq815 @YongxueHong Could you please help to take a review here? Thanks

Copy link
Contributor

@YongxueHong YongxueHong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants