-
Notifications
You must be signed in to change notification settings - Fork 182
virtio_fs_set_capability: adding --inode-file-handle=never #4436
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
WalkthroughA single configuration line is added to Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes 🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In `@qemu/tests/cfg/virtio_fs_set_capability.cfg`:
- Line 90: Update the virtiofsd option string appended to
fs_binary_extra_options: replace the incorrect singular flag
"--inode-file-handle=never" with the correct plural "--inode-file-handles=never"
so the fs_binary_extra_options concatenation uses the proper virtiofsd option
name.
production changed the default of -inode-file-handles from never to prefer, so to have the previous behavior you need to pass --inode-file-handle=never Signed-off-by: Tingting Mao <[email protected]>
|
(1/1) Host_RHEL.m10.u2.ovmf.qcow2.virtio_blk.up.virtio_net.Guest.RHEL.9.7.0.x86_64.io-github-autotest-qemu.virtio_fs_set_capability.remove_capability.cap_dac_read_search.with_cache.auto.q35: PASS (100.52 s) @fbq815 @YongxueHong Could you please help to take a review here? Thanks |
YongxueHong
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
production changed the default of -inode-file-handles from never to prefer, so to have the previous behavior you need to pass --inode-file-handle=never
ID: 4839
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.