Skip to content

feat: goal planner checking border; clean up #10725 #10755

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

Owen-Liuyuxuan
Copy link
Contributor

Description

Filter out objects that are separated from the ego vehicle by road borders, preventing unnecessary path planning considerations for objects on the opposite side of road infrastructure.

Algorithm

(New)
Enhanced Goal Planner Road Border Filtering

(before 6/1)
Goal Planner Road Border Filtering Visualization

Before

Screenshot from 2025-05-28 12-00-57

After

Screenshot from 2025-05-28 12-04-45

Related links

Parent Issue:

How was this PR tested?

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

Signed-off-by: YuxuanLiuTier4Desktop <[email protected]>
@github-actions github-actions bot added type:documentation Creating or refining documentation. (auto-assigned) component:planning Route planning, decision-making, and navigation. (auto-assigned) labels Jun 4, 2025
Copy link

github-actions bot commented Jun 4, 2025

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@Owen-Liuyuxuan Owen-Liuyuxuan added run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) tag:require-cuda-build-and-test labels Jun 4, 2025
Signed-off-by: YuxuanLiuTier4Desktop <[email protected]>
Copy link

codecov bot commented Jun 4, 2025

Codecov Report

Attention: Patch coverage is 0% with 53 lines in your changes missing coverage. Please review.

Project coverage is 16.32%. Comparing base (30d7335) to head (fd34bb0).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...are_behavior_path_goal_planner_module/src/util.cpp 0.00% 50 Missing ⚠️
...th_goal_planner_module/src/goal_planner_module.cpp 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10755      +/-   ##
==========================================
+ Coverage   15.67%   16.32%   +0.65%     
==========================================
  Files        1338     1346       +8     
  Lines       98877    99644     +767     
  Branches    32308    32614     +306     
==========================================
+ Hits        15500    16269     +769     
- Misses      71516    72042     +526     
+ Partials    11861    11333     -528     
Flag Coverage Δ *Carryforward flag
daily 17.03% <ø> (+<0.01%) ⬆️ Carriedforward from 86321b6
daily-cuda 15.67% <ø> (+<0.01%) ⬆️ Carriedforward from 86321b6
differential 8.28% <0.00%> (?)
total-cuda 15.67% <ø> (+0.01%) ⬆️ Carriedforward from 86321b6

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@kosuke55 kosuke55 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM again!

@Owen-Liuyuxuan Owen-Liuyuxuan merged commit 747e6d9 into autowarefoundation:main Jun 4, 2025
44 of 45 checks passed
@github-project-automation github-project-automation bot moved this from To Triage to Done in Software Working Group Jun 4, 2025
mkquda pushed a commit to tier4/autoware_universe that referenced this pull request Jun 16, 2025
…autowarefoundation#10755)

* merging updates  in autowarefoundation#10725

Signed-off-by: YuxuanLiuTier4Desktop <[email protected]>

* fix hash and typo, precommit

Signed-off-by: YuxuanLiuTier4Desktop <[email protected]>

---------

Signed-off-by: YuxuanLiuTier4Desktop <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) tag:require-cuda-build-and-test type:documentation Creating or refining documentation. (auto-assigned)
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants