Skip to content

feat(next-gen): onboarding (existing seedphrase) #269

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: feat/ng-onboarding-first-screen
Choose a base branch
from

Conversation

meeh0w
Copy link
Member

@meeh0w meeh0w commented May 19, 2025

⚠️ Based on #264
⚠️ No worries, plenty of added lines is due to the SVG images included (over 40 avatars). Feel free to focus on reviewing from the 2nd commit onwards.

Description

Changes

  • Adds a bunch of avatar SVGs
  • Adds the common screens (choice between seedphrase/ledger/keystone + wallet details form + avatar selector + success screen)
  • Adds the whole recovery phrase import flow
  • I removed the mocky Onboarding.test.tsx file, because it was failing due to some Jest config stuff I didn't want to focus on at the moment (importing images).

Testing

  • Clear your storage
  • Onboard with existing seedphrase
  • After onboarding, you should see the "Under construction" text

Screenshots:

Screen.Recording.2025-05-23.at.23.15.31.mov

Checklist for the author

  • I've covered new/modified business logic with Jest test cases.
  • I've tested the changes myself before sending it to code review and QA.

@meeh0w meeh0w changed the base branch from main to chore/new-app May 19, 2025 13:57
@semgrep-code-ava-labs
Copy link

Semgrep found 2 ssc-b5cd4801-a3c5-43d5-bca5-c7fdef10f97b findings:

  • packages/service-worker/src/services/featureFlags/FeatureFlagService.ts

Risk: Affected versions of semver are vulnerable to Inefficient Regular Expression Complexity. The vulnerability exists in the package semver allowing Regular Expression Denial of Service (ReDoS) through the new Range when untrusted user data is input as a range.

Fix: Upgrade this library to at least version 7.5.2 at core-extension/yarn.lock:30864.

Reference(s): GHSA-c2qf-rxjj-qqgw, CVE-2022-25883

@meeh0w meeh0w changed the base branch from chore/new-app to feat/ng-onboarding-first-screen May 19, 2025 17:21
@meeh0w meeh0w force-pushed the feat/ng-onboarding-first-screen branch 2 times, most recently from 97e975c to 77a5d4e Compare May 22, 2025 12:33
@meeh0w meeh0w force-pushed the feat/ng-onboarding-common-screens branch from e3db96a to b60f18c Compare May 23, 2025 21:00
@meeh0w meeh0w changed the title Feat/ng onboarding common screens feat(next-gen): onboarding (existing seedphrase) May 23, 2025
@meeh0w meeh0w marked this pull request as ready for review May 23, 2025 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants