Skip to content

feat: command buttons #275

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

feat: command buttons #275

wants to merge 2 commits into from

Conversation

vvava
Copy link
Contributor

@vvava vvava commented May 21, 2025

Description

Changes

Testing

Screenshots:

Checklist for the author

Tick each of them when done or if not applicable.

  • I've covered new/modified business logic with Jest test cases.
  • I've tested the changes myself before sending it to code review and QA.

@vvava vvava added the DO NOT MERGE This PR is not meant to be merged in its current state label May 21, 2025
Comment on lines +709 to +725
<Stack
sx={{
position: 'absolute',
bottom: '80px',
left: 0,
width: 'auto',
zIndex: 1,
}}
>
<Button
variant="contained"
sx={{ my: 0.5 }}
onClick={() => {
prompt('Tokens list');
setIsCommandsOpen(false);
}}
>
Copy link

@bartosz-the-coder-at-avalabs bartosz-the-coder-at-avalabs May 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please consider to use gap property of the Stack component to control the space between the buttons.
It will also result in removal of all sx={{ my: 0.5 }} lines

Suggested change
<Stack
sx={{
position: 'absolute',
bottom: '80px',
left: 0,
width: 'auto',
zIndex: 1,
}}
>
<Button
variant="contained"
sx={{ my: 0.5 }}
onClick={() => {
prompt('Tokens list');
setIsCommandsOpen(false);
}}
>
<Stack
gap={0.5}
sx={{
position: 'absolute',
bottom: '80px',
left: 0,
width: 'auto',
zIndex: 1,
}}
>
<Button
variant="contained"
onClick={() => {
prompt('Tokens list');
setIsCommandsOpen(false);
}}
>

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you but this was only a PoC PR I won't merge it anyway :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DO NOT MERGE This PR is not meant to be merged in its current state
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants