-
Notifications
You must be signed in to change notification settings - Fork 12
feat: command buttons #275
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
<Stack | ||
sx={{ | ||
position: 'absolute', | ||
bottom: '80px', | ||
left: 0, | ||
width: 'auto', | ||
zIndex: 1, | ||
}} | ||
> | ||
<Button | ||
variant="contained" | ||
sx={{ my: 0.5 }} | ||
onClick={() => { | ||
prompt('Tokens list'); | ||
setIsCommandsOpen(false); | ||
}} | ||
> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please consider to use gap
property of the Stack
component to control the space between the buttons.
It will also result in removal of all sx={{ my: 0.5 }}
lines
<Stack | |
sx={{ | |
position: 'absolute', | |
bottom: '80px', | |
left: 0, | |
width: 'auto', | |
zIndex: 1, | |
}} | |
> | |
<Button | |
variant="contained" | |
sx={{ my: 0.5 }} | |
onClick={() => { | |
prompt('Tokens list'); | |
setIsCommandsOpen(false); | |
}} | |
> | |
<Stack | |
gap={0.5} | |
sx={{ | |
position: 'absolute', | |
bottom: '80px', | |
left: 0, | |
width: 'auto', | |
zIndex: 1, | |
}} | |
> | |
<Button | |
variant="contained" | |
onClick={() => { | |
prompt('Tokens list'); | |
setIsCommandsOpen(false); | |
}} | |
> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you but this was only a PoC PR I won't merge it anyway :)
Description
Changes
Testing
Screenshots:
Checklist for the author
Tick each of them when done or if not applicable.