[CP-10577] feat: add lock screen #278
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bartosz-the-coder-at-avalabs
had a problem deploying
to
alpha
GitHub Actions
Failure
There was a problem hiding this comment.
I converted the hook to the utility to reflect its actual function
bartosz-the-coder-at-avalabs
had a problem deploying
to
alpha
GitHub Actions
Failure
bartosz-the-coder-at-avalabs
had a problem deploying
to
alpha
GitHub Actions
Failure
bartosz-the-coder-at-avalabs
had a problem deploying
to
alpha
GitHub Actions
Failure
bartosz-the-coder-at-avalabs
had a problem deploying
to
alpha
GitHub Actions
Failure
bartosz-the-coder-at-avalabs
had a problem deploying
to
alpha
GitHub Actions
Failure
bartosz-the-coder-at-avalabs
had a problem deploying
to
alpha
GitHub Actions
Failure
bartosz-the-coder-at-avalabs
had a problem deploying
to
alpha
GitHub Actions
Failure
bartosz-the-coder-at-avalabs
had a problem deploying
to
alpha
GitHub Actions
Failure
bartosz-the-coder-at-avalabs
requested a deployment
to
alpha
GitHub Actions
Waiting
bartosz-the-coder-at-avalabs
had a problem deploying
to
alpha
GitHub Actions
Failure
meeh0w
approved these changes
May 23, 2025
There was a problem hiding this comment.
I left some small comments, but it looks really good. 👏
CI is failing, but those are some easy fixes too.
You'll need to run yarn scanner:next - this is our script to update the translation files based on the tokens passed to the translation function (t('...')).
To replicate the other issues please run yarn test:next / yarn typecheck:next / yarn lint:next, etc.
I pre-approved so people know this was reviewed (once you push new commits, my approval may get revoked by Github).
meeh0w
force-pushed
the
feat/ng-onboarding-common-screens
branch
from
e3db96a to
b60f18c
Compare
refactor: update AnalyticsContextProvider & useAppDimensions dupson feat: init
fix: typing issue chore: cleanup
# This is the 1st commit message: fix: fix unlock form spacing # This is the commit message #2: fix: size of LoginButton
fix: size of LoginButton fix: more spacing & sizing fixes
bartosz-the-coder-at-avalabs
force-pushed
the
feat/CP-10577
branch
from
6305bc4 to
90b3bbb
Compare
bartosz-the-coder-at-avalabs
had a problem deploying
to
alpha
GitHub Actions
Failure
bartosz-the-coder-at-avalabs
had a problem deploying
to
alpha
GitHub Actions
Failure
bartosz-the-coder-at-avalabs
had a problem deploying
to
alpha
GitHub Actions
Failure
bartosz-the-coder-at-avalabs
temporarily deployed
to
alpha
GitHub Actions
Inactive
bartosz-the-coder-at-avalabs
force-pushed
the
feat/CP-10577
branch
from
e8dd781 to
82b0b3e
Compare
bartosz-the-coder-at-avalabs
temporarily deployed
to
alpha
GitHub Actions
Inactive
csabbee
approved these changes
May 27, 2025
bartosz-the-coder-at-avalabs
merged commit 52a2985
into
feat/ng-onboarding-common-screens
2 checks passed
bartosz-the-coder-at-avalabs
added a commit
that referenced
this pull request
May 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Lock Screen has been added.
The unlocking, forget password and no connection features work as expected.
FIGMA
Changes
The PR introduces LockScreen component which purpose is to unlock the user's wallet.
Testing
Screenshots:
Checklist for the author
Tick each of them when done or if not applicable.