Skip to content

Use go run for tools #783

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Use go run for tools #783

wants to merge 4 commits into from

Conversation

geoff-vball
Copy link
Contributor

@geoff-vball geoff-vball commented Jun 3, 2025

Why this should be merged

go run pulls the version directly from go.mod, reducing a bit of complexity here. Also makes the E2E tests work if your GO_PATH isn't in your PATH.

Analog of ava-labs/icm-contracts#796

How this works

This is the current recommended way to manage tools in go. Now dependabot will also automate updating these dependencies. In go1.24, there will be a better way https://blog.howardjohn.info/posts/go-tools-command/

How this was tested

How is this documented

@geoff-vball geoff-vball changed the title Use go run for ginkgo Use go run for tools Jun 3, 2025
Copy link
Contributor

@iansuvak iansuvak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the ginkgo changes, I'm a bit more ambivalent on buf and golangci-lint since the runtime doesn't need them but I'm fine including them

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants