feat: RIP-7212 precompile for P256 ECDSA verification #184
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yacovm
reviewed
Jun 4, 2025
yacovm
reviewed
Jun 4, 2025
yacovm
reviewed
Jun 4, 2025
yacovm
reviewed
Jun 4, 2025
yacovm
reviewed
Jun 4, 2025
yacovm
reviewed
Jun 4, 2025
yacovm
approved these changes
Jun 4, 2025
scammi
reviewed
Jun 5, 2025
scammi
reviewed
Jun 5, 2025
furkan-ux
approved these changes
Jun 10, 2025
alarso16
approved these changes
Jun 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
Implementation for ACP-204.
How this works
Implements RIP-7212 and an additional
Pack(hash,r,s,key)function with precompile-compatible output.How this was tested
Unit tests including fuzzing, test case from the proposed but unmerged geth implementation, and vectors from Project Wycheproof.