feat: RulesHooks.MinimumGasConsumption
#185
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ARR4N
changed the title
RulesHooks.MinimumGasSpendRulesHooks.MinimumGasConsumption
Co-authored-by: Stephen Buttolph <[email protected]> Signed-off-by: Arran Schlosberg <[email protected]>
StephenButtolph
approved these changes
Jun 11, 2025
Co-authored-by: Stephen Buttolph <[email protected]> Signed-off-by: Arran Schlosberg <[email protected]>
Co-authored-by: Stephen Buttolph <[email protected]> Signed-off-by: Arran Schlosberg <[email protected]>
Co-authored-by: Stephen Buttolph <[email protected]> Signed-off-by: Arran Schlosberg <[email protected]>
ARR4N
added a commit
that referenced
this pull request
Jun 11, 2025
## Why this should be merged #185 was allowed to merge despite CI requiring the `lint` job. ## How this works Fix linter issues. ## How this was tested The first commit is an empty commit, expected to fail CI, to confirm that the job is in fact required.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
Required for ACP-194$\lambda$ bound on gas consumption.
How this works
Hook into
core.StateTransition.TransitionDb()as this is the bottom of all execution paths (e.g.core.ApplyTransaction()as used in SAE,core.StateProcessor.Process(*Block,...), etc.). Once consumed gas is no longer changing (i.e. after all spends and refunds), the transaction limit is passed to the hook to determine the minimum consumption, which is applied.How this was tested
Unit test via
core.ApplyTransaction()as this is our entry point in SAE.