autoipd: fixed missing 'else' for predictable behavior conditional blocks #688
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pemensik
approved these changes
Oct 19, 2025
Collaborator
|
avahi-autoipd isn't actively maintained anymore: #467, #709 so issues aren't addressed in general and it should be announced that it's deprecated soon (dhcpcd, NetworkManager and systemd-networkd support IPv4LL out of the box these days and can be used instead) Can you expand on how this issue was discovered? Was it a static analyzer or is it still used somewhere? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@evverx,
behavior will be unexpected with any
RTM_*ADDRand invertediis distinguishable from conditional bodyif ( ... cond body ... ).