fix: try harder to decrement CurrentByHostname metric

avast · Mar 20, 2023 · ff52c13 · ff52c13
1 parent f70c27c
commit ff52c13
Showing 1 changed file with 12 additions and 1 deletion.
diff --git a/grpc/src/main/java/com/avast/metrics/grpc/GrpcServerMonitoringInterceptor.java b/grpc/src/main/java/com/avast/metrics/grpc/GrpcServerMonitoringInterceptor.java
@@ -31,8 +31,14 @@ public <ReqT, RespT> ServerCall.Listener<ReqT> interceptCall(final ServerCall<Re
         final AtomicInteger currentCalls = cache.getGaugedValueByHostname(method, "CurrentByHostname");
         final Instant start = clock.instant();
 
+        CurrentCallsReleaser currentCallsReleaser;
         currentCalls.incrementAndGet();
-        final CurrentCallsReleaser currentCallsReleaser = new CurrentCallsReleaser(currentCalls);
+        try {
+            currentCallsReleaser = new CurrentCallsReleaser(currentCalls);
+        } catch(Throwable ex) {
+            currentCalls.decrementAndGet();
+            throw ex;
+        }
 
         final ServerCall<ReqT, RespT> newCall = new ForwardingServerCall.SimpleForwardingServerCall<ReqT, RespT>(call) {
             @Override
@@ -113,5 +119,10 @@ void release() {
                 currentCalls.decrementAndGet();
             }
         }
+
+        @Override
+        protected void finalize() {
+            release();
+        }
     }
 }