feat: Find Compose files #130
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikeroll
force-pushed
the
find-compose
branch
2 times, most recently
from
d0faebb to
4d8d52a
Compare
mikeroll
force-pushed
the
find-compose
branch
from
4d8d52a to
6bb9b98
Compare
Contributor
Author
|
Actually, scratch that, I just realized I've reimplemented the file discovery logic of compose in python. I'd rather look into omitting |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tl;dr is I really wanted to have my compose file called
compose.yaml- it is the preferred default now.docker_compose_filewill now try each option until it finds an existing file, falling back to the old default ofdocker-compose.yml.