Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: MLOPS-474 wanna-ml managed notebooks fail to create when labels … #102

Merged
merged 1 commit into from
Sep 1, 2023

Conversation

jsilva
Copy link
Collaborator

@jsilva jsilva commented Sep 1, 2023

Describe your changes

wanna-ml managed notebooks fail to create when labels or metadata is set

Issue ticket number and link

MLOPS-474

Checklist before requesting a review

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • If it is a core feature, I have added thorough tests.

@codecov-commenter
Copy link

Codecov Report

Patch and project coverage have no change.

Comparison is base (0aceb1d) 74.42% compared to head (dfee095) 74.42%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #102   +/-   ##
=======================================
  Coverage   74.42%   74.42%           
=======================================
  Files          57       57           
  Lines        2839     2839           
=======================================
  Hits         2113     2113           
  Misses        726      726           
Files Changed Coverage Δ
src/wanna/core/services/managed_notebook.py 62.02% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jsilva jsilva marked this pull request as ready for review September 1, 2023 09:22
@jsilva jsilva merged commit b59a582 into master Sep 1, 2023
4 checks passed
@jsilva jsilva deleted the joao/mlops-474 branch September 1, 2023 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants