Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: some updates #133

Merged
merged 2 commits into from
Aug 27, 2024
Merged

docs: some updates #133

merged 2 commits into from
Aug 27, 2024

Conversation

racinmat
Copy link
Contributor

@racinmat racinmat commented Aug 26, 2024

Describe your changes

  • renamed plugins to cli reference
  • added docs about the stack traces
  • updated some dependencies
  • explicit utf-8 encoding, should prevent weird windows bugs, because they use windows-1252 by default.

The scantree was added as part of #112
The scandir was added along with dirhash in #89

The tests are passing locally on windows.

Issue ticket number and link

fixes #129
fixes #130

Checklist before requesting a review

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • If it is a core feature, I have added thorough tests.

added docs about the stack traces
updated some dependencies
explicit encoding, should prevent weird windows bugs
@racinmat racinmat requested a review from jsilva August 26, 2024 14:53
@racinmat racinmat changed the title docs, chore: some updates docs: some updates Aug 26, 2024
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 50.00000% with 5 lines in your changes missing coverage. Please review.

Project coverage is 74.46%. Comparing base (048ca40) to head (ffde8e1).
Report is 3 commits behind head on master.

Files Patch % Lines
src/wanna/core/services/docker.py 20.00% 4 Missing ⚠️
.../wanna/components/kubeflow/upload_model_version.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master     #133   +/-   ##
=======================================
  Coverage   74.46%   74.46%           
=======================================
  Files          58       58           
  Lines        2867     2867           
=======================================
  Hits         2135     2135           
  Misses        732      732           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@racinmat racinmat requested a review from a team August 27, 2024 11:45
@racinmat racinmat merged commit 588c7d0 into master Aug 27, 2024
4 checks passed
@racinmat racinmat deleted the racinsky/versions-chore branch August 27, 2024 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants