Migrate CI to build wheels via cibuildwheel + update of dependencies #282
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is already required by yaramod itself and reduces in less warnings produced
metthal
force-pushed
the
fix/upgrade-deps
branch
2 times, most recently
from
1e52e1f to
3abea79
Compare
metthal
force-pushed
the
fix/upgrade-deps
branch
2 times, most recently
from
02f52af to
5393e01
Compare
metthal
force-pushed
the
fix/upgrade-deps
branch
from
5393e01 to
da52b71
Compare
It seems like there might be issues with this and only 1 core is used in some cases
metthal
changed the title
metthal
force-pushed
the
fix/upgrade-deps
branch
2 times, most recently
from
a7155a2 to
da1599c
Compare
metthal
force-pushed
the
fix/upgrade-deps
branch
from
da1599c to
5b9eb17
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I would like to split this PR but I really cannot because we needed both update of dependencies so that even newer clang can be used to compile yaramod + we had to migrate away from directly using manylinux to cibuildwheel, which in turn allowed us to easily build wheels for Linux, Windows and macOS.