Skip to content

Expose EllipseColliderShape and RegularPolygonColliderShape #596

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Jondolf merged 1 commit into from
Dec 14, 2024
Merged

Expose EllipseColliderShape and RegularPolygonColliderShape #596

Jondolf merged 1 commit into from
Dec 14, 2024

Conversation

@Jondolf
Copy link
Member

@Jondolf Jondolf commented Dec 14, 2024

Objective

Fixes #595.

Currently, EllipseWrapper and RegularPolygonWrapper are not public, so you cannot access their information at runtime for colliders.

Solution

Make them public, and rename them to EllipseColliderShape and RegularPolygonColliderShape for clarity.

@Jondolf Jondolf added C-Feature A new feature, making something new possible A-Collision Relates to the broad phase, narrow phase, colliders, or other collision functionality labels Dec 14, 2024
@Jondolf Jondolf mentioned this pull request Dec 14, 2024
Closed
@Jondolf Jondolf merged commit b47c30c into main Dec 14, 2024
5 checks passed
@Jondolf Jondolf deleted the public-shape-wrappers branch December 14, 2024 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

A-Collision Relates to the broad phase, narrow phase, colliders, or other collision functionality C-Feature A new feature, making something new possible

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Unable to get custom type shaped colliders

2 participants

@Jondolf