Skip to content

Introduce PhysicsPickingFilter #632

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Jondolf merged 6 commits into from
Jan 30, 2025
Merged

Introduce PhysicsPickingFilter #632

Jondolf merged 6 commits into from
Jan 30, 2025

Conversation

@morgenthum
Copy link
Contributor

@morgenthum morgenthum commented Jan 15, 2025

See #631

@morgenthum
Copy link
Contributor Author

morgenthum commented Jan 15, 2025

I removed the RenderLayers checks, because it would be too complicated to configure picking, if we have CollisionLayers, RenderLayers and the new PhysicsPickingLayers on the camera.

@Jondolf Jondolf added C-Feature A new feature, making something new possible A-Spatial-Query Relates to spatial queries, such as ray casting, shape casting, and intersection tests M-Migration-Guide A breaking change to Avian's public API that needs to be noted in a migration guide labels Jan 17, 2025
@Jondolf Jondolf added this to the 0.3 milestone Jan 17, 2025
Jondolf
Jondolf approved these changes Jan 29, 2025
View reviewed changes
Copy link
Member

@Jondolf Jondolf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! I pushed some changes to replace PhysicsPickingLayers with a PhysicsPickingFilter component that stores a whole SpatialQueryFilter instead of just a layer mask, like I proposed on Discord :)

Also made some small doc improvements and added the component to the prelude. I intend to merge this tomorrow.

@Jondolf Jondolf changed the title Introduce PhysicsPickingLayers Introduce PhysicsPickingFilter Jan 30, 2025
@Jondolf Jondolf merged commit 11e64a1 into avianphysics:main Jan 30, 2025
5 checks passed
@Jondolf Jondolf mentioned this pull request Feb 5, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Jondolf Jondolf Jondolf approved these changes

Assignees

No one assigned

Labels

A-Spatial-Query Relates to spatial queries, such as ray casting, shape casting, and intersection tests C-Feature A new feature, making something new possible M-Migration-Guide A breaking change to Avian's public API that needs to be noted in a migration guide

Projects

None yet

Milestone

0.3

Development

Successfully merging this pull request may close these issues.

2 participants

@morgenthum @Jondolf