-
Notifications
You must be signed in to change notification settings - Fork 33
re-enable precompilation #716
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #716 +/- ##
=======================================
Coverage 86.91% 86.91%
=======================================
Files 13 13
Lines 2821 2821
=======================================
Hits 2452 2452
Misses 369 369 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
b859365
to
8cee808
Compare
aviatesk
added a commit
to aviatesk/JETLS.jl
that referenced
this pull request
Jun 5, 2025
This change significantly improves latency between language server startup and receiving the first completion after typing. When combined with aviatesk/JET.jl#716, startup time is considerably enhanced.
Also precompiles the top-level analysis code. From [CHANGELOG.md](./CHANGELOG.md): > Precompilation of JET has been re-enabled. This should significantly improve > startup times: > ```bash > $ julia --startup-file=no -e ' > macro simpletime(ex) > :(let s = time() > $(ex) > e = time() > elapsed = round(e - s; digits=2) > println(" Elapsed: $elapsed sec") > end) > end > @SimpleTime using JET > @SimpleTime @report_call sum("julia") > @SimpleTime report_file(normpath(pkgdir(JET), "demo.jl"); toplevel_logger=nothing)' > ``` > ``` > v0.10.6 > Elapsed: 1.25 sec > Elapsed: 10.08 sec > Elapsed: 11.43 sec > This version > Elapsed: 1.33 sec > Elapsed: 0.01 sec > Elapsed: 0.14 sec > ``` > > This makes the precompilation during installation take longer. > If you're developing JET itself, we recommend having: > > LocalPreferences.toml > ```toml > [JET] > precompile_workload = false > ```
69973cc
to
d53ce42
Compare
aviatesk
added a commit
to aviatesk/JETLS.jl
that referenced
this pull request
Jun 6, 2025
This change significantly improves latency between language server startup and receiving the first completion after typing. When combined with aviatesk/JET.jl#716, startup time is considerably enhanced. From the new README section: > JETLS uses [precompilation](https://julialang.github.io/PrecompileTools.jl/stable/) > to reduce the latency between server startup and the user receiving first > responses. > Once you install the JETLS package and precompile it, the language server will > start up quickly afterward (until you upgrade the JETLS version), providing > significant benefits from the user's perspective. > > However, during development, when you're frequently rewriting JETLS code itself, > running time-consuming precompilation after each modification might be a waste > of time. In such cases, you can disable precompilation by adding the following > settings to your LocalPreferences.toml: > > LocalPreferences.toml > ```toml > [JETLS] > precompile_workload = false # Disable precompilation for JETLS > > [JET] > precompile_workload = false # Also disable precompilation for JET if you're developing it simultaneously > ```
aviatesk
added a commit
to aviatesk/JETLS.jl
that referenced
this pull request
Jun 6, 2025
This change significantly improves latency between language server startup and receiving the first completion after typing. When combined with aviatesk/JET.jl#716, startup time is considerably enhanced. From the new README section: > JETLS uses [precompilation](https://julialang.github.io/PrecompileTools.jl/stable/) > to reduce the latency between server startup and the user receiving first > responses. > Once you install the JETLS package and precompile it, the language server will > start up quickly afterward (until you upgrade the JETLS version), providing > significant benefits from the user's perspective. > > However, during development, when you're frequently rewriting JETLS code itself, > running time-consuming precompilation after each modification might be a waste > of time. In such cases, you can disable precompilation by adding the following > settings to your LocalPreferences.toml: > > LocalPreferences.toml > ```toml > [JETLS] > precompile_workload = false # Disable precompilation for JETLS > > [JET] > precompile_workload = false # Also disable precompilation for JET if you're developing it simultaneously > ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also precompiles the top-level analysis code.
From CHANGELOG.md: