Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Package ppc64-diag is now a part of Appstream not baseOS. #2903

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Package ppc64-diag is now a part of Appstream not baseOS. #2903

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ras/packages.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ def setUp(self):

self.sm = SoftwareManager()
self.packages = self.params.get(
'packages', default=['powerpc-utils', 'ppc64-diag', 'lsvpd'])
'packages', default=['powerpc-utils', 'ppc64-diag-rtas', 'lsvpd'])
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Krishan-Saraswat why are we adding the default packages again here?
your hard coding them in yaml. I feel they are needed again as default packages.
Please move them either to .py file as we have other testcases, or take support of yaml file

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Krishan-Saraswat if I understand correctly, ppc64-diag split in two package one is ppc64-diag and other is ppc64-diag-rtas and ppc64-diag is no more default package ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this correct this will be applicable only for the latest distro then we should still have support for the old distro

if 'PowerNV' in open('/proc/cpuinfo', 'r').read():
self.packages.extend(['opal-prd'])

Expand Down
6 changes: 3 additions & 3 deletions ras/packages.py.data/list.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
packages: ['powerpc-utils', 'ppc64-diag', 'lsvpd', 'powerpc-utils-core']
packages_rhel: ['lshw', 'librtas']
packages_ubuntu: ['librtas2']
packages: ["powerpc-utils", "ppc64-diag-rtas", "lsvpd", "powerpc-utils-core"]
packages_rhel: ["lshw", "librtas"]
packages_ubuntu: ["librtas2"]
Loading