Skip to content

Extended parameters (-x and -E) improvements #1844

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 21 commits into from
Jul 31, 2024
Merged

Extended parameters (-x and -E) improvements #1844

Changes from 1 commit
Commits
Show all changes
21 commits
Select commit Hold shift + click to select a range
aebf970
Add -xautoreset option for the AVR109 programmer
MCUdude Jul 22, 2024
5e4a9a7
Add -xno_autoreset for the -c arduino programmer
MCUdude Jul 22, 2024
0d7524d
Add -xno_autoreset for the -c wiring programmer
MCUdude Jul 22, 2024
c3d97e9
Add -xnoautoreset for the -c urclock programmer
stefanrueger Jul 28, 2024
94e968a
Use %i instead of %2d
MCUdude Jul 28, 2024
12c41f2
Small tweaks based on feedback from @stefanrueger
MCUdude Jul 28, 2024
cda52a3
Fix autoreset flag for -c arduino
MCUdude Jul 28, 2024
c1a0378
Print -x help text when invalid extended option is passed
MCUdude Jul 29, 2024
568bb8e
Use bool instead of int for help flag
MCUdude Jul 29, 2024
313c8b4
Print helptext for all programmers that supports extended params when…
MCUdude Jul 29, 2024
f37e593
Clarify invalid value messages for valid -x parameters ...
stefanrueger Jul 29, 2024
df5d1fe
Add remaining spaces after -x in messages
stefanrueger Jul 29, 2024
41e7d81
Fix issue where help flag wasn't set when it should
MCUdude Jul 29, 2024
9658908
check if pgm->type is Arduino instead of pgmid
MCUdude Jul 29, 2024
95b4e78
Improve -x help for the remaining programmers
MCUdude Jul 29, 2024
3c679b1
Add help text for -E exitspec
MCUdude Jul 29, 2024
297d256
Fix incorrect noautoreset implementation for the Wiring programmer op…
MCUdude Jul 29, 2024
38da070
Fix bug in the serprog ext parameters parsing
MCUdude Jul 29, 2024
77db93b
Fix formatting and missing brackets
MCUdude Jul 29, 2024
a874b52
help flag should be false by default
MCUdude Jul 29, 2024
92a2729
help flag should be false by default, again
MCUdude Jul 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions src/jtag3.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1610,9 +1610,10 @@ static int jtag3_parseextparms(const PROGRAMMER *pgm, const LISTID extparms) {
rv = -1;
}
msg_error("%s -c %s extended options:\n", progname, pgmid);
if(str_eq(pgm->type, "JTAGICE3"))
if(str_eq(pgm->type, "JTAGICE3")) {
msg_error(" -x jtagchain=UB,UA,BB,BA Setup the JTAG scan chain order\n");
msg_error(" UB/UA = units before/after, BB/BA = bits before/after\n");
msg_error(" UB/UA = units before/after, BB/BA = bits before/after\n");
}
if(lsize(pgm->hvupdi_support) > 1)
msg_error(" -x hvupdi Enable high-voltage UPDI initialization\n");
if(pgm->extra_features & HAS_SUFFER) {
Expand Down