Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add detail to part and programmer lists in avrdude.pdf #1895

Merged
merged 19 commits into from
Aug 23, 2024

Conversation

stefanrueger
Copy link
Collaborator

The -c ? and -p ? lists in the documentation have been moved to appendices and beefed up with programming modes and, for -p, with alternative names. Parts and programmers are now automatically put into the index.

@stefanrueger stefanrueger changed the title Add detail to part and programmer list in avrdude.pdf Add detail to part and programmer lists in avrdude.pdf Aug 22, 2024
@stefanrueger
Copy link
Collaborator Author

@ndim I am guessing (but do not know) that the autotools run fails b/c the files programmers.sed and parts.sed are only in this PR but not (yet) in the repository itself (where they would be after merging). So reckon the failing check is a red herring. But what do I know?

@ndim
Copy link
Contributor

ndim commented Aug 22, 2024

@ndim I am guessing (but do not know) that the autotools run fails b/c the files programmers.sed and parts.sed are only in this PR but not (yet) in the repository itself (where they would be after merging). So reckon the failing check is a red herring. But what do I know?

See my review comments. Probably. I am on a mobile phone right now, cannot really check.

@mcuee mcuee added documentation Improvements or additions to documentation enhancement New feature or request labels Aug 22, 2024
@stefanrueger
Copy link
Collaborator Author

@ndim Thanks, I am having a hard time to find your review comments. No worries if they were lost somehow.

@ndim
Copy link
Contributor

ndim commented Aug 22, 2024

@ndim Thanks, I am having a hard time to find your review comments. No worries if they were lost somehow.

The make recipes need to refer to $(srcdir)/parts.sed and $(srcdir)/programmers.sed. Both in the dependency declaration and in the body of the recipe.

@stefanrueger stefanrueger merged commit 42589c0 into avrdudes:main Aug 23, 2024
12 checks passed
@stefanrueger stefanrueger deleted the avrdude.pdf branch August 23, 2024 01:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants