Skip to content

CI: Ensure only supported configure options are used (--enable-option-checking=fatal) #1934

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 23, 2024
Merged

CI: Ensure only supported configure options are used (--enable-option-checking=fatal) #1934

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
79e091b
ci: Use multi-line format to invoke configure
ndim Nov 20, 2024
b8594d1
ci: Fix macos brew install issue with pkg-config
ndim Nov 20, 2024
172474a
ci: Abort autotools builds in case of unsupported options
ndim Nov 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
40 changes: 30 additions & 10 deletions .github/workflows/build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,6 +63,7 @@ jobs:
mkdir _ambuild && cd _ambuild

../src/configure
--enable-option-checking=fatal
--enable-doc
--enable-parport
--enable-linuxgpio
Expand Down Expand Up @@ -218,10 +219,12 @@ jobs:
runs-on: macos-latest
steps:
- uses: actions/checkout@v3
- name: Original PATH and build tools
run: |
echo "PATH=$PATH"
for b in bison flex pkg-config; do type "$b"; done
- name: Install prerequisites
run: >-
# brew update

brew install
cmake
flex
Expand All @@ -233,12 +236,18 @@ jobs:
libftdi
readline
libserialport
pkg-config
- name: Configure environment to use brew kegs for flex and bison
run: |
echo "PATH=/opt/homebrew/opt/flex/bin:/opt/homebrew/opt/bison/bin:$PATH" >> $GITHUB_ENV
- name: post-brew PATH and build tools
run: |
echo "PATH=$PATH"
for b in bison flex pkg-config; do type "$b"; done
- name: Configure
run: >-
cmake
-D CMAKE_C_FLAGS=-I/opt/homebrew/include
-D CMAKE_EXE_LINKER_FLAGS=-L/opt/homebrew/Cellar
-D CMAKE_C_FLAGS="-I/opt/homebrew/include -I/opt/homebrew/opt/flex/include"
-D CMAKE_EXE_LINKER_FLAGS="-L/opt/homebrew/Cellar -L/opt/homebew/opt/flex/lib"
-D DEBUG_CMAKE=1
-D CMAKE_BUILD_TYPE=${{env.BUILD_TYPE}}
-B build
Expand Down Expand Up @@ -269,10 +278,12 @@ jobs:
runs-on: macos-latest
steps:
- uses: actions/checkout@v3
- name: Original PATH and build tools
run: |
echo "PATH=$PATH"
for b in bison flex pkg-config; do type "$b"; done
- name: Install prerequisites
run: >-
# brew update

brew install
automake
autoconf
Expand All @@ -286,15 +297,24 @@ jobs:
libftdi
readline
libserialport
pkg-config
- name: Configure environment to use brew kegs for flex and bison
run: |
echo "PATH=/opt/homebrew/opt/flex/bin:/opt/homebrew/opt/bison/bin:$PATH" >> $GITHUB_ENV
- name: post-brew PATH and build tools
run: |
echo "PATH=$PATH"
for b in bison flex pkg-config; do type "$b"; done
- name: Configure
run: >-
./src/bootstrap

mkdir _ambuild && cd _ambuild

CFLAGS="-I/opt/homebrew/include" LDFLAGS="-L/opt/homebrew/lib" ../src/configure

CFLAGS="-I/opt/homebrew/include -I/opt/homebrew/opt/flex/include"
LDFLAGS="-L/opt/homebrew/lib -L/opt/homebrew/opt/bison/lib"
../src/configure
--enable-option-checking=fatal

- name: Build
run: make -C _ambuild -j$(nproc)
- name: "avrdude -? (not installed)"
Expand Down
Loading