-
Notifications
You must be signed in to change notification settings - Fork 242
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Upgrade to Node 20, remove deprecation warnings, upgrade CI deprecations #537
chore: Upgrade to Node 20, remove deprecation warnings, upgrade CI deprecations #537
Conversation
@efekarakus / @dannyrandall / AWS maintainers (📯) , it would be great if you had any time to have a look at getting these deprecations looked at, cheers! |
Any updates to this? |
2 months to go for the Github enforcement of Node 20 usage! https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/ I'm not sure how this will impact users, but it would be really nice for the community to have this upgrade done before that date. This is a great Github Action and I would love to keep using it. Let me know if I can help in any way to get this merged! |
@KollaAdithya thanks for approving and merging this! Can we get a release now? |
Hi there, I see this has been merged but I don't see a release yet, should we just point to master or wait for a release? |
@KollaAdithya https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/
|
Starting to wonder if this action is still maintained. |
I pinned the commit SHA instead of the version |
Fix for #535
The upgrading of the checkout action is a dup of this PR which hasn't had much attention given to it, this is a safe upgrade though so just pulling it in here anyway: #471
This is currently affecting my workflows by adding lots of annotations, cluttering up the Actions experience. 😞
It would be great if the maintainers here could upgrade the Node version to resolve this. This PR is a start on that, I'm not sure if I've missed anything. Tested it on our repo and it seems to work.
Thanks