Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Upgrade to Node 20, remove deprecation warnings, upgrade CI deprecations #537

Merged

Conversation

singhprd
Copy link
Contributor

@singhprd singhprd commented Feb 7, 2024

Fix for #535

The upgrading of the checkout action is a dup of this PR which hasn't had much attention given to it, this is a safe upgrade though so just pulling it in here anyway: #471

  • Use non-deprecated node runtime
  • Brucey bonus: Upgrade to non-deprecated checkout action (v2 -> v4)
  • Update yarn lockfile
  • Update dist

This is currently affecting my workflows by adding lots of annotations, cluttering up the Actions experience. 😞
Screenshot 2024-02-07 at 12 44 35

It would be great if the maintainers here could upgrade the Node version to resolve this. This PR is a start on that, I'm not sure if I've missed anything. Tested it on our repo and it seems to work.

Thanks

@singhprd singhprd changed the title use node 20 remove deprecation warnings Upgrade to Node 20, remove deprecation warnings, upgrade CI deprecations Feb 7, 2024
@singhprd singhprd marked this pull request as ready for review February 7, 2024 12:46
@singhprd
Copy link
Contributor Author

singhprd commented Feb 7, 2024

@efekarakus / @dannyrandall / AWS maintainers (📯) , it would be great if you had any time to have a look at getting these deprecations looked at, cheers!

@TheMoonDawg
Copy link

Any updates to this?

@almiavicas
Copy link

2 months to go for the Github enforcement of Node 20 usage! https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/

I'm not sure how this will impact users, but it would be really nice for the community to have this upgrade done before that date. This is a great Github Action and I would love to keep using it. Let me know if I can help in any way to get this merged!

@KollaAdithya KollaAdithya changed the title Upgrade to Node 20, remove deprecation warnings, upgrade CI deprecations chore: Upgrade to Node 20, remove deprecation warnings, upgrade CI deprecations Mar 19, 2024
@mergify mergify bot merged commit 302cdae into aws-actions:master Mar 19, 2024
8 checks passed
@ZsoltPath
Copy link

@KollaAdithya thanks for approving and merging this! Can we get a release now?

@cabello
Copy link

cabello commented Apr 1, 2024

Hi there, I see this has been merged but I don't see a release yet, should we just point to master or wait for a release?

@jedipunkz
Copy link

@KollaAdithya
Please release tag. GitHub plans to transition to run on Node 20 by Spring 2024.

https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/

Our plan is to transition all actions to run on Node 20 by Spring 2024. We will actively monitor the migration's progress and gather community feedback before finalizing the transition date.

@wilkinson4
Copy link

Starting to wonder if this action is still maintained.

@patrick-scully-ef
Copy link

Starting to wonder if this action is still maintained.

I pinned the commit SHA instead of the version

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants