Skip to content

docs: make description for "service" parameter less ambiguous. #539

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 4, 2024

Conversation

lmller
Copy link
Contributor

@lmller lmller commented Feb 20, 2024

The description for the "service" param states:

"The name of the ECS service to deploy to. The action will only register the task definition if no service is given."

But in this case "only" is not meant as a condition, but as a limitation...
I stumbled upon this ambiguity in the documentation and it cost me an hour of my life, so I thought I might as well change it :-)

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@amazreech
Copy link
Contributor

Hi @lmller,

Thank you for your Patience. We appreciate your contribution to the repository and will be working to review the changes in the Pull Request.

In the mean time please ensure below steps are taken care of in your PR:

  1. Verify if PR follows semantic pull request conventions.
    Example: change PR title to follow conventions.

  2. Please be sure to rebase and resolve merge any conflicts on the PR, if necessary.

@lmller lmller changed the title Make description for "service" parameter less ambiguous. docs: make description for "service" parameter less ambiguous. May 23, 2024
@amazreech amazreech merged commit 1d62636 into aws-actions:master Jun 4, 2024
6 checks passed
project0 pushed a commit to project0/amazon-ecs-deploy-task-definition that referenced this pull request Jun 4, 2024
docs: make description for "service" parameter less ambiguous.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants