Skip to content

feat: add new feature for one-off tasks #580

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 0 commits into from

Conversation

shesaave
Copy link
Contributor

@shesaave shesaave commented Jul 15, 2024

Issue #, if available: #54 and #304 and #273

Description of changes: This feature is known as a one-off task. These changes allow a single task to run outside of a service.

Implemented Tests

The ability to have a one off task run with default inputs

  • You can run your task with any inputs the default ones are always there for secure compilation.

The ability to have a one off task run with desired settings

  • You can select the desired settings for your one-off task and remove any if needed

The ability to have a one off task run and also a service

  • You can select the desired settings for your one-off task and remove any if needed
  • You can run your service with the desired setting and inputs

Checking when a task stops if it stops/fails properly

  • you are able to use one of these options for your one-off task: wait-for-task-stopped
  • if this input is selected your task should run and call the wait-for-task-stopped conditionals and API runTask
  • Otherwise, a separate tests allows an error can appear indicating that the input didn't properly run

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Copy link
Contributor

@kg-aws kg-aws left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are 2 Github checks failing so please look into it as well along with the feedback.

@shesaave shesaave changed the title One-off task feature feat: One-off task Jul 18, 2024
@shesaave shesaave changed the title feat: One-off task feat: add one-off task Jul 18, 2024
@shesaave shesaave changed the title feat: add one-off task feat: add one-off task feature Jul 18, 2024
@shesaave shesaave self-assigned this Jul 18, 2024
@shesaave shesaave changed the title feat: add one-off task feature feat: add new feature for one-off tasks Jul 18, 2024
Copy link
Contributor

@amazreech amazreech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding this comment/review to prevent automatic merging of this PR for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants