Skip to content

Add new integration tests for newly added one off task #594

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 39 commits into from
Jul 31, 2024
Merged

Add new integration tests for newly added one off task #594

merged 39 commits into from
Jul 31, 2024

Conversation

shesaave
Copy link
Contributor

@shesaave shesaave commented Jul 30, 2024 •
edited
Loading

Issue #, if available: #54 and #304 and #273

Description of changes:

  • Added changes to test one-off task inputs
  • Made description names of each test more precise
  • The task-definition-run-task.json allows the one off task to successfully run when using a example of task definition from ECS

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

shesaave added 29 commits June 24, 2024 15:16
@shesaave
update tasks only feature
3202f19
@shesaave
merge with remote
c8a36e1
@shesaave
new integration tests
b92d314
@shesaave
new integration tests with env variables defined
d833b92
@shesaave
updated inputs
98f6d60
@shesaave
updated cluster inputs
57829c7
@shesaave
updated region
b586061
@shesaave
Update test-workflow.yml
5c3d9db
@shesaave
updated subnet values
b886b56
@shesaave
updated subnet values
774a9bb
@shesaave
updated values to link to my subnets, repo, cluster, and my service
038fdd1
@shesaave
update security group
f017483
@shesaave
modified workflow to add public IP and task definition with proper in…
b2e6e58 
…puts
@shesaave
new task def file and yaml file changes
ef56b9c
@shesaave
updated task def run task file with different container information
4247e8f
@shesaave
updated task def run task file with new cpu
91e9ed2
@shesaave
new changes for integ tests with deploy task def credentials
a63b1ef
@shesaave
updating task definition
5097930
@shesaave
updating env variables to inputs
23d4244
@shesaave
updated region
a84b8c8
@shesaave
updated env to both workflow files
b5db699
@shesaave
removing env block
3d45493
@shesaave
removing old commit and using commit from offical deploy repo
87b02dc
@shesaave
new echo integ test run no.
cb5f1e8
@shesaave
update original task definition
777e820
@shesaave
remove public IP input
2b2e22b
@shesaave
keep only basic run task inputs
d3be320
@shesaave
original inputs and different security group
58c566a
@shesaave
final changes
071cc21
amazreech
amazreech requested changes Jul 30, 2024
View reviewed changes
Copy link
Contributor

@amazreech amazreech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Blocking Automatic Merging, waiting for additional approvals.

omkhegde
omkhegde requested changes Jul 31, 2024
View reviewed changes
@omkhegde
Copy link
Contributor

I believe .idea folder should not be checked in, please add it to .gitignore and remove from PR.

amazreech
amazreech reviewed Jul 31, 2024
View reviewed changes
amazreech
amazreech reviewed Jul 31, 2024
View reviewed changes
Copy link
Contributor

@amazreech amazreech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me for the most part. Few things to improve could be:

  • renaming step names on both .github/workflow/test-workflow.yml file and the test-workflow.yml file.
  • Adding a PR description about what the new task-definition-run-task.json does.

@shesaave shesaave merged commit e7a19b2 into aws-actions:integ-tests Jul 31, 2024
1 check passed
shesaave added a commit that referenced this pull request Jul 31, 2024
@shesaave
Revert "chore: Add new integration tests for newly added one off task (…
c9a10ef 
…#594)"

This reverts commit e7a19b2.
@shesaave shesaave mentioned this pull request Jul 31, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@omkhegde omkhegde omkhegde approved these changes

@amazreech amazreech amazreech approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shesaave @omkhegde @amazreech