fix: add workflow cancellation support#840
Open
scarf005 wants to merge 3 commits intoaws-actions:masterfrom
Open
fix: add workflow cancellation support#840scarf005 wants to merge 3 commits intoaws-actions:masterfrom
scarf005 wants to merge 3 commits intoaws-actions:masterfrom
Conversation
adds AbortController to support workflow cancellation by listening to SIGINT and SIGTERM signals. see: https://docs.github.com/en/actions/reference/workflows-and-actions/workflow-cancellation fixes aws-actions#9
Contributor
|
Thanks for this @scarf005! Could you add a dedicated test that actually fires the cancellation signal (e.g. emitting |
Add a dedicated cancellation test that emits SIGTERM during service stabilization and verifies the abort signal cancels the waiter. Co-authored-by: chatgpt-codex-connector[bot] <199175422+chatgpt-codex-connector[bot]@users.noreply.github.com> Assisted-by: openai/gpt-5.3-codex on opencode
Merge upstream master into workflow-cancellation branch while preserving cancellation-abort behavior and aligning max-delay waiter tests. Co-authored-by: chatgpt-codex-connector[bot] <199175422+chatgpt-codex-connector[bot]@users.noreply.github.com> Assisted-by: openai/gpt-5.3-codex on opencode
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #9
Description of changes:
adds AbortController to support workflow cancellation by listening to SIGINT and SIGTERM signals.
see: https://docs.github.com/en/actions/reference/workflows-and-actions/workflow-cancellation
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.