chore: add source map to ncc transpilation#391
Open
pose wants to merge 2 commits intoaws-actions:mainfrom
Open
chore: add source map to ncc transpilation#391pose wants to merge 2 commits intoaws-actions:mainfrom
pose wants to merge 2 commits intoaws-actions:mainfrom
Conversation
Before this change when the action failed, a very verbose message was displayed that is preventing properly debugging issues. By introducing source maps, it would be now possible to understand what's causing the error.
pose
commented
Jan 22, 2026
package.json
Outdated
| "description": "GitHub Action that cleans up old and response-reqested issues", | ||
| "private": true, | ||
| "main": "dist/entrypoint.js", | ||
| "main": "dist/index.js", |
Author
There was a problem hiding this comment.
This is unrelated, but it should point to dist/index.js since there's no dist/entrypoint.js file. I know the GH Action still works, but took me a minute or two of scratching my head.
pose
commented
Jan 22, 2026
| "test": "npm run lint && vitest run && npm run build", | ||
| "build": "tsc", | ||
| "package": "npm run build && ncc build -m --license THIRD-PARTY -o dist && node -e \"require('fs').cpSync('dist/THIRD-PARTY', './THIRD-PARTY')\"", | ||
| "package": "npm run build && ncc build -s -m --license THIRD-PARTY -o dist && node -e \"require('fs').cpSync('dist/THIRD-PARTY', './THIRD-PARTY')\"", |
Author
There was a problem hiding this comment.
-s toggles source maps: https://github.com/vercel/ncc#options . Given the size of the script, I don't believe there would be any noticeable performance degradation and it would help users troubleshoot future problems.
pose
force-pushed
the
pose/chores/better-stack-traces
branch
from
60cee8a to
4005077
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available: N/A
Description of changes: Before this change when the action failed, a very verbose message was displayed that is preventing properly debugging issues. By introducing source maps, it would be now possible to understand what's causing the error.
For instance, here is one error GitHub Action workflow error which I am not able to diagnose due to this: https://github.com/pulumi/pulumi-kubernetes/actions/runs/21197820169/job/60977392333#step:2:730
Here is a sample of how an error that I manually triggered will look like (using
act):By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.