Skip to content

Conversation

@mattcreaser
Copy link
Member

  • PR title and description conform to Pull Request guidelines.

Issue #, if available:

Description of changes:
Resolved a few warnings in our Gradle builds

  • Using deprecated project.buildDir (should be project.layout.buildDirectory)
  • Using unsupported build tools (build tools version is now set automatically by AGP)
  • Specifying useless targetSdk in a library project (only app projects should set targetSdk)
  • Using deprecated packagingOptions (renamed to packaging)
  • Unable to resolve androidx.annotation:annotation:1.1.0 - I'm not sure why this happens since that artifact does exist, but upgrading to 1.9.1 appears to resolve 🤷‍♂️

This PR does not resolve compilation warnings, only warnings from the Gradle build itself.

How did you test these changes?

  • Ran clean build, observed no more warnings

Documentation update required?

  • No
  • Yes (Please include a PR link for the documentation update)

General Checklist

  • Added Unit Tests
  • Added Integration Tests
  • Security oriented best practices and standards are followed (e.g. using input sanitization, principle of least privilege, etc)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@mattcreaser mattcreaser requested a review from a team as a code owner January 14, 2025 15:49
@mattcreaser mattcreaser enabled auto-merge (squash) January 16, 2025 13:49
@mattcreaser mattcreaser merged commit 83992a6 into main Jan 16, 2025
3 checks passed
@mattcreaser mattcreaser deleted the mattcreaser/gradle-warnings branch January 16, 2025 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants