chore: Resolve warnings in Gradle scripts#2972
Merged
mattcreaser merged 3 commits intomainfrom Jan 16, 2025
Merged
Conversation
tylerjroach
approved these changes
Jan 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Resolved a few warnings in our Gradle builds
project.buildDir(should beproject.layout.buildDirectory)targetSdkin a library project (only app projects should set targetSdk)packagingOptions(renamed topackaging)androidx.annotation:annotation:1.1.0- I'm not sure why this happens since that artifact does exist, but upgrading to 1.9.1 appears to resolve 🤷♂️This PR does not resolve compilation warnings, only warnings from the Gradle build itself.
How did you test these changes?
Documentation update required?
General Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.