Skip to content

Conversation

@mattcreaser
Copy link
Member

  • PR title and description conform to Pull Request guidelines.

Issue #, if available:

Description of changes:
These tests are frequently failing on CI. This appears to happen because the initial delay is too small, so the first update often gets missed by the observer. This is easy to reproduce locally by setting a small initial delay (like 10) which will cause the tests to often fail locally. On CI the delay needs to be much higher.

How did you test these changes?

Documentation update required?

  • No
  • Yes (Please include a PR link for the documentation update)

General Checklist

  • Added Unit Tests
  • Added Integration Tests
  • Security oriented best practices and standards are followed (e.g. using input sanitization, principle of least privilege, etc)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@mattcreaser mattcreaser requested a review from a team as a code owner February 11, 2025 20:15
@mattcreaser mattcreaser merged commit 508a1d8 into main Feb 11, 2025
4 checks passed
@mattcreaser mattcreaser deleted the mattcreaser/rx-storage-binding-test branch February 11, 2025 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants