chore(auth): Migrate TOTP setup to use case classes#2992
Merged
mattcreaser merged 2 commits intomainfrom Feb 28, 2025
Merged
Conversation
Contributor
|
I've noticed this error will never surface anymore: This looks like it was just a generic catch all but want to make sure the change is expected. |
Member
Author
|
The string there is the message set on unmapped exception types (i.e. if we return an If we wanted to retain the contextual message we can do something like: internal inline fun <R> mapExceptions(fallbackMessage: String, block: () -> R): R {
try {
return block()
} catch (e: Exception) {
throw CognitoAuthExceptionConverter.lookup(e, fallbackMessage)
}
}and then suspend fun execute(): TOTPSetupDetails = mapExceptions("Cannot setup TOTP") {
// ....
} |
Contributor
|
Thanks for clarification. I am ok with original change. |
tylerjroach
previously approved these changes
Feb 24, 2025
The base branch was changed.
0921e41 to
2a06e44
Compare
tylerjroach
approved these changes
Feb 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
setupTotpwhere Amplify would hang (never invoke callbacks) in certain scenarios.How did you test these changes?
Documentation update required?
General Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.