Skip to content

Conversation

@mattcreaser
Copy link
Member

@mattcreaser mattcreaser commented Apr 8, 2025

  • PR title and description conform to Pull Request guidelines.

Issue #, if available:

Description of changes:
Moves the delete user functionality to a use case and adds unit tests covering this functionality.

How did you test these changes?
Unit tests
Test app

Documentation update required?

  • No
  • Yes (Please include a PR link for the documentation update)

General Checklist

  • Added Unit Tests
  • Added Integration Tests
  • Security oriented best practices and standards are followed (e.g. using input sanitization, principle of least privilege, etc)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@mattcreaser mattcreaser requested a review from a team as a code owner April 8, 2025 18:24
vincetran
vincetran previously approved these changes Apr 8, 2025
Base automatically changed from mattcreaser/usecase-auto-sign-in to main April 9, 2025 21:34
@mattcreaser mattcreaser dismissed vincetran’s stale review April 9, 2025 21:34

The base branch was changed.

@codecov
Copy link

codecov bot commented Apr 10, 2025

Codecov Report

Attention: Patch coverage is 81.25000% with 6 lines in your changes missing coverage. Please review.

Project coverage is 41.91%. Comparing base (7f874ed) to head (da0256d).
Report is 60 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3015      +/-   ##
==========================================
- Coverage   44.01%   41.91%   -2.11%     
==========================================
  Files         926      992      +66     
  Lines       30485    31495    +1010     
  Branches     4351     4636     +285     
==========================================
- Hits        13419    13202     -217     
- Misses      15601    16855    +1254     
+ Partials     1465     1438      -27     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mattcreaser mattcreaser force-pushed the mattcreaser/usecase-delete-user branch from da0256d to 01c4cf0 Compare April 10, 2025 16:12
@mattcreaser mattcreaser merged commit 179a95f into main Apr 11, 2025
3 checks passed
@mattcreaser mattcreaser deleted the mattcreaser/usecase-delete-user branch April 11, 2025 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants