feat(data): Events API Connection ack timeout handling #3020
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vincetran
approved these changes
Apr 14, 2025
|
Addressed @mattcreaser 's previous PR comments from: #3018 |
mattcreaser
reviewed
Apr 15, 2025
| val connectionInitMessage = json.encodeToString(WebSocketMessage.Send.ConnectionInit()) | ||
| logger?.debug { "$TAG onOpen: sending connection init" } | ||
| webSocket.send(connectionInitMessage) | ||
| logger?.debug { "onOpen: sending connection init" } |
There was a problem hiding this comment.
Static logs like this can use direct function invocation instead of lambda form
There was a problem hiding this comment.
fixed for all the simple, non throwable providing log types.
| // so inspecting code/reason isn't helpful as it should be | ||
| logger?.debug("$TAG onClosed: userInitiated = $userInitiatedDisconnect") | ||
| notifyClosed() | ||
| logger?.debug("onClosed: reason = $disconnectReason") |
There was a problem hiding this comment.
Logs with concatenation should probably be using lambda form
mattcreaser
approved these changes
Apr 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
How did you test these changes?
(Please add a line here how the changes were tested)
Documentation update required?
General Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.