feat(data): Update Events API Contract #3029
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattcreaser
approved these changes
Apr 24, 2025
Comment on lines
40
to
41
| okHttpClient: OkHttpClient, | ||
| loggerProvider: LoggerProvider?, |
There was a problem hiding this comment.
Why remove Options here instead of making it private val? Seems it would be simpler to keep it as the number of options potentially grows.
There was a problem hiding this comment.
I had originally created this internal constructor to make the okhttp client injectable to inject a mocking interceptor. Technically this isn't needed now so I can revert back to just using the public constructor.
There was a problem hiding this comment.
Pushed change. @mattcreaser can you reapprove
mattcreaser
approved these changes
Apr 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
How did you test these changes?
(Please add a line here how the changes were tested)
Documentation update required?
General Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.