fix(auth): Update exception handling for devices that don't support passkeys#3044
Merged
mattcreaser merged 2 commits intomainfrom May 6, 2025
Merged
Conversation
vincetran
approved these changes
May 5, 2025
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3044 +/- ##
==========================================
+ Coverage 41.96% 42.01% +0.05%
==========================================
Files 992 992
Lines 31542 31546 +4
Branches 4645 4648 +3
==========================================
+ Hits 13237 13255 +18
+ Misses 16860 16830 -30
- Partials 1445 1461 +16 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
If CredentialManager tells us a device doesn't support passkeys then throw a
WebAuthnNotSupportedExceptioninstead of generalWebAuthnException.Added unit tests.
How did you test these changes?
Unit tests
Replicate on pre-Android 28 device
Documentation update required?
General Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.