fix(auth): Remove WindowManager usage from DeviceDataCollector#3061
Merged
mattcreaser merged 1 commit intomainfrom May 14, 2025
Merged
fix(auth): Remove WindowManager usage from DeviceDataCollector#3061mattcreaser merged 1 commit intomainfrom
mattcreaser merged 1 commit intomainfrom
Conversation
tylerjroach
approved these changes
May 14, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3061 +/- ##
==========================================
+ Coverage 42.00% 42.07% +0.07%
==========================================
Files 992 992
Lines 31546 31544 -2
Branches 4648 4648
==========================================
+ Hits 13251 13273 +22
+ Misses 16834 16809 -25
- Partials 1461 1462 +1 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available: #3057
Description of changes:
Use displayMetrics to get the size of the display instead of WindowManager. Added unit tests.
How did you test these changes?
Verified that app crashes on signIn if the following strictMode is used, but does not crash afterwards:
Verified that the same device size is returned before and after the change.
Documentation update required?
General Checklist
fix(storage): message,feat(auth): message,chore(all): message)By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.