Skip to content

Conversation

@mattcreaser
Copy link
Member

@mattcreaser mattcreaser commented May 14, 2025

  • PR title and description conform to Pull Request guidelines.

Issue #, if available: #3057

Description of changes:
Use displayMetrics to get the size of the display instead of WindowManager. Added unit tests.

How did you test these changes?
Verified that app crashes on signIn if the following strictMode is used, but does not crash afterwards:

StrictMode.setVmPolicy(
    StrictMode.VmPolicy.Builder()
        .detectIncorrectContextUse()
        .penaltyLog()
        .penaltyDeath()
        .build()
)

Verified that the same device size is returned before and after the change.

Documentation update required?

  • No
  • Yes (Please include a PR link for the documentation update)

General Checklist

  • Added Unit Tests
  • Added Integration Tests
  • Security oriented best practices and standards are followed (e.g. using input sanitization, principle of least privilege, etc)
  • Ensure commit message has the appropriate scope (e.g fix(storage): message, feat(auth): message, chore(all): message)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@mattcreaser mattcreaser requested a review from a team as a code owner May 14, 2025 14:36
@codecov
Copy link

codecov bot commented May 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 42.07%. Comparing base (a63c2b9) to head (214f6bc).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3061      +/-   ##
==========================================
+ Coverage   42.00%   42.07%   +0.07%     
==========================================
  Files         992      992              
  Lines       31546    31544       -2     
  Branches     4648     4648              
==========================================
+ Hits        13251    13273      +22     
+ Misses      16834    16809      -25     
- Partials     1461     1462       +1     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mattcreaser mattcreaser merged commit 319f5f1 into main May 14, 2025
6 checks passed
@mattcreaser mattcreaser deleted the mattcreaser/auth-strict-mode branch May 14, 2025 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants