Skip to content

Conversation

@tylerjroach
Copy link
Member

  • PR title and description conform to Pull Request guidelines.

Issue #, if available:

Description of changes:
In some API test cases, results were in the paged list, so tests were failing by not getting the expected total counts. This ensure's that all lazy model lists fetch all pages.

How did you test these changes?
(Please add a line here how the changes were tested)

Documentation update required?

  • No
  • Yes (Please include a PR link for the documentation update)

General Checklist

  • Added Unit Tests
  • Added Integration Tests
  • Security oriented best practices and standards are followed (e.g. using input sanitization, principle of least privilege, etc)
  • Ensure commit message has the appropriate scope (e.g fix(storage): message, feat(auth): message, chore(all): message)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@tylerjroach tylerjroach requested a review from a team as a code owner May 19, 2025 15:41
@codecov
Copy link

codecov bot commented May 19, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 42.08%. Comparing base (e31b961) to head (eaa4b80).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3065   +/-   ##
=======================================
  Coverage   42.07%   42.08%           
=======================================
  Files         992      992           
  Lines       31544    31544           
  Branches     4648     4648           
=======================================
+ Hits        13273    13274    +1     
+ Misses      16808    16807    -1     
  Partials     1463     1463           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

vincetran
vincetran previously approved these changes May 19, 2025
@tylerjroach tylerjroach changed the title fix(data) Stabilize API tests fix(data) Stabilize API/Auth tests May 19, 2025
@tylerjroach tylerjroach enabled auto-merge (squash) May 20, 2025 18:25
@tylerjroach tylerjroach merged commit efef6b1 into main May 20, 2025
5 checks passed
@tylerjroach tylerjroach deleted the tjroach/fix-api-test-paging branch May 20, 2025 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants