fix(auth): Emit SIGNED_IN event after autoSignIn #3068
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: #3064
Description of changes:
Fixes two issues found in AutoSignInUseCase:
first()terminal operator, which cancels flow collection as soon as the sign in result is received. This would cancel the suspended coroutine and thus it never resumes to proceed to emitting the hub event.I also changed the transforming function from
transformWhiletomapNotNullto make it more obvious that the collector is cancelled when the result is emitted.How did you test these changes?
Documentation update required?
General Checklist
fix(storage): message,feat(auth): message,chore(all): message)By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.