Skip to content

Conversation

@mattcreaser
Copy link
Member

@mattcreaser mattcreaser commented May 22, 2025

  • PR title and description conform to Pull Request guidelines.

Issue #, if available:

Description of changes:
Fixes unclosed databases in the unit tests for cloudwatch logging plugin. This was addressed in version 2.9.0 of the WorkManager test artifact, which added the closeWorkDatabase() function. (see here)

I updated to 2.9.1, which is the latest version that didn't require adjusting our compile SDK.

I replaced the workmanager-runtime-ktx dependency with workmanager-runtime because as of version 2.9.0 the KTX functionality was promoted to the main artifact, and workmanager-runtime-ktx is now empty.

How did you test these changes?
Verified that no error logs emitted by these tests.

Documentation update required?

  • No
  • Yes (Please include a PR link for the documentation update)

General Checklist

  • Added Unit Tests
  • Added Integration Tests
  • Security oriented best practices and standards are followed (e.g. using input sanitization, principle of least privilege, etc)
  • Ensure commit message has the appropriate scope (e.g fix(storage): message, feat(auth): message, chore(all): message)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@mattcreaser mattcreaser requested a review from a team as a code owner May 22, 2025 16:41
@mattcreaser mattcreaser closed this Jun 5, 2025
@mattcreaser mattcreaser reopened this Jun 5, 2025
@mattcreaser
Copy link
Member Author

mattcreaser commented Jun 6, 2025

The WorkManager upgrade removed an internal implementation class that one of our test classes was using. I'll need to find a replacement for that. edit: Done

@mattcreaser mattcreaser force-pushed the mattcreaser/unclosed-test-database branch from 8f0e127 to fa4564e Compare June 6, 2025 13:12
@codecov
Copy link

codecov bot commented Jun 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 51.95%. Comparing base (c365bd7) to head (0c2b391).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3070   +/-   ##
=======================================
  Coverage   51.94%   51.95%           
=======================================
  Files        1033     1033           
  Lines       31335    31335           
  Branches     4537     4537           
=======================================
+ Hits        16278    16281    +3     
+ Misses      13369    13367    -2     
+ Partials     1688     1687    -1     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mattcreaser mattcreaser enabled auto-merge (squash) June 11, 2025 14:47
@mattcreaser mattcreaser merged commit ae14a5c into main Jun 11, 2025
15 of 16 checks passed
@mattcreaser mattcreaser deleted the mattcreaser/unclosed-test-database branch June 11, 2025 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants