chore: Fix auth integ test crashing when test fails#3077
Closed
chore: Fix auth integ test crashing when test fails#3077
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3077 +/- ##
==========================================
- Coverage 54.36% 54.35% -0.01%
==========================================
Files 1033 1033
Lines 31591 31591
Branches 4587 4587
==========================================
- Hits 17173 17170 -3
- Misses 12649 12651 +2
- Partials 1769 1770 +1 🚀 New features to boost your workflow:
|
mattcreaser
approved these changes
Sep 8, 2025
Member
|
This PR was superseded by #3143 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available: N/A
Description of changes:
As such, by calling the JUnit fail() or assert*() methods from within any of the onSuccess/onFailure callbacks would end up crashing the integration test because those callbacks are ultimately called within a coroutine.
Used helper methods provided by Matt to refactor all of the integration tests to use them which also simplifies the test code overall so we don't need to actually use a latch anymore.
How did you test these changes?
(Please add a line here how the changes were tested)
Documentation update required?
General Checklist
fix(storage): message,feat(auth): message,chore(all): message)By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.