Skip to content

Conversation

@vincetran
Copy link
Member

  • PR title and description conform to Pull Request guidelines.

Issue #, if available: N/A

Description of changes: This change adds support for Rekognition's new configuration for the liveness challenge where the UI component does not render a series of flashing colors on the screen. This configuration is referred to as the "no light" challenge and comes in from Rekognition as the FaceMovementChallenge as opposed to the FaceMovementAndLightClientChallenge.

How did you test these changes? These changes were already reviewed as part of #2841 and #2883

Documentation update required?

General Checklist

  • Added Unit Tests
  • Added Integration Tests
  • Security oriented best practices and standards are followed (e.g. using input sanitization, principle of least privilege, etc)
  • Ensure commit message has the appropriate scope (e.g fix(storage): message, feat(auth): message, chore(all): message)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@vincetran vincetran requested a review from a team as a code owner June 27, 2025 19:39
@codecov
Copy link

codecov bot commented Jun 27, 2025

Codecov Report

Attention: Patch coverage is 43.36735% with 111 lines in your changes missing coverage. Please review.

Project coverage is 54.46%. Comparing base (40a2075) to head (848e772).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3083      +/-   ##
==========================================
+ Coverage   54.36%   54.46%   +0.10%     
==========================================
  Files        1033     1038       +5     
  Lines       31591    31713     +122     
  Branches     4587     4598      +11     
==========================================
+ Hits        17173    17272      +99     
- Misses      12649    12674      +25     
+ Partials     1769     1767       -2     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@vincetran vincetran merged commit d530c3e into main Jun 30, 2025
14 of 16 checks passed
@vincetran vincetran deleted the feat/no-light-sku-refresh branch June 30, 2025 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants