Skip to content

chore: fix jar signatures for publishing #3101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 1, 2025
Merged

chore: fix jar signatures for publishing #3101

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion annotations/gradle.properties
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
POM_ARTIFACT_ID=annotations
POM_NAME=Amplify Framework for Android - Annotations
POM_DESCRIPTION=Amplify Framework for Android - Annotations for AWS Amplify Libraries
POM_PACKAGING=aar
POM_PACKAGING=jar
9 changes: 9 additions & 0 deletions build-logic/plugins/src/main/kotlin/KotlinConventionPlugin.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ import org.gradle.api.Project
import org.gradle.api.tasks.compile.JavaCompile
import org.gradle.api.tasks.testing.Test
import org.gradle.kotlin.dsl.configure
import org.gradle.kotlin.dsl.extra
import org.gradle.kotlin.dsl.withType
import org.jetbrains.kotlin.gradle.dsl.KotlinProjectExtension
import org.jetbrains.kotlin.gradle.tasks.KotlinCompile
Expand Down Expand Up @@ -44,6 +45,14 @@ class KotlinConventionPlugin : Plugin<Project> {
}

with(target) {
// Set up signing properties for publishing
if (hasProperty("signingKeyId")) {
println("Getting signing info from protected source.")
extra["signing.keyId"] = findProperty("signingKeyId")
extra["signing.password"] = findProperty("signingPassword")
extra["signing.inMemoryKey"] = findProperty("signingInMemoryKey")
}

configure<KotlinProjectExtension> {
jvmToolchain(17)
}
Expand Down