Skip to content

Conversation

@mattcreaser
Copy link
Member

  • PR title and description conform to Pull Request guidelines.

Issue #, if available: #3102

Description of changes:
The "connect" suffix was being applied to the actual websocket subscription connection URL, and not just in the IAM signature generation logic as intended. This could cause connection issues as in the linked issue. This change removes the "connect" suffix from the connection url and only applies it when calculating the signature for the request.

How did you test these changes?

  • Verified subscriptions work as expected with IAM and other authorization modes.

Documentation update required?

  • No
  • Yes (Please include a PR link for the documentation update)

General Checklist

  • Added Unit Tests
  • Added Integration Tests
  • Security oriented best practices and standards are followed (e.g. using input sanitization, principle of least privilege, etc)
  • Ensure commit message has the appropriate scope (e.g fix(storage): message, feat(auth): message, chore(all): message)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@mattcreaser mattcreaser requested a review from a team as a code owner August 21, 2025 14:46
@codecov
Copy link

codecov bot commented Aug 22, 2025

Codecov Report

❌ Patch coverage is 75.00000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 54.22%. Comparing base (fa82953) to head (3651fac).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3114      +/-   ##
==========================================
- Coverage   54.23%   54.22%   -0.02%     
==========================================
  Files        1038     1038              
  Lines       31991    31989       -2     
  Branches     4702     4702              
==========================================
- Hits        17351    17346       -5     
- Misses      12794    12795       +1     
- Partials     1846     1848       +2     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mattcreaser mattcreaser enabled auto-merge (squash) August 25, 2025 13:35
@mattcreaser mattcreaser merged commit e7425e8 into main Aug 25, 2025
18 of 19 checks passed
@mattcreaser mattcreaser deleted the mattcreaser/apollo-remove-connect-suffix branch August 25, 2025 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants