Skip to content

Conversation

@mattcreaser
Copy link
Member

  • PR title and description conform to Pull Request guidelines.

Issue #, if available:

Description of changes:
Updates internal handling of auth tokens to wrap them in typesafe classes instead of bare strings. This makes the codebase easier to understand, drastically cuts down on the number of times the JWT strings are parsed, and makes it less likely that token content is accidentally leaked (because the masking is applied at the wrapper class level).

How did you test these changes?

Documentation update required?

  • No
  • Yes (Please include a PR link for the documentation update)

General Checklist

  • Added Unit Tests
  • Added Integration Tests
  • Security oriented best practices and standards are followed (e.g. using input sanitization, principle of least privilege, etc)
  • Ensure commit message has the appropriate scope (e.g fix(storage): message, feat(auth): message, chore(all): message)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@mattcreaser mattcreaser requested a review from a team as a code owner September 4, 2025 16:47
@mattcreaser mattcreaser force-pushed the mattcreaser/auth-tokens branch from 8f4a00f to b94e0e2 Compare September 11, 2025 19:06
@codecov
Copy link

codecov bot commented Sep 11, 2025

Codecov Report

❌ Patch coverage is 53.48837% with 40 lines in your changes missing coverage. Please review.
✅ Project coverage is 54.28%. Comparing base (288a082) to head (da58ec1).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3123      +/-   ##
==========================================
+ Coverage   54.27%   54.28%   +0.01%     
==========================================
  Files        1040     1040              
  Lines       32071    32078       +7     
  Branches     4712     4721       +9     
==========================================
+ Hits        17406    17414       +8     
+ Misses      12824    12818       -6     
- Partials     1841     1846       +5     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mattcreaser mattcreaser enabled auto-merge (squash) September 15, 2025 15:51
tylerjroach
tylerjroach previously approved these changes Sep 16, 2025
Copy link
Member

@tylerjroach tylerjroach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice simplification!

@mattcreaser mattcreaser merged commit 0474838 into main Sep 22, 2025
16 of 17 checks passed
@mattcreaser mattcreaser deleted the mattcreaser/auth-tokens branch September 22, 2025 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants