-
Notifications
You must be signed in to change notification settings - Fork 127
fix(data): Fix GroupQueryPredicate Serialization for LastSyncMetadata stored syncExpression #3124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fixes bug introduced here: #2937 |
Closed
1 task
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #3124 +/- ##
==========================================
+ Coverage 54.24% 54.26% +0.02%
==========================================
Files 1038 1040 +2
Lines 32008 32062 +54
Branches 4703 4712 +9
==========================================
+ Hits 17364 17400 +36
- Misses 12805 12823 +18
Partials 1839 1839 🚀 New features to boost your workflow:
|
mattcreaser
reviewed
Sep 8, 2025
...ync/src/main/java/com/amplifyframework/core/model/query/predicate/GsonPredicateAdapters.java
Show resolved
Hide resolved
.../src/test/java/com/amplifyframework/core/model/query/predicate/GsonPredicateAdaptersTests.kt
Outdated
Show resolved
Hide resolved
.../java/com/amplifyframework/datastore/storage/sqlite/SQLiteStorageHelperInstrumentedTest.java
Show resolved
Hide resolved
.../java/com/amplifyframework/datastore/storage/sqlite/SQLiteStorageHelperInstrumentedTest.java
Show resolved
Hide resolved
...oidTest/java/com/amplifyframework/datastore/storage/sqlite/SQLiteStorageAdapterCreateTest.kt
Outdated
Show resolved
Hide resolved
mattcreaser
approved these changes
Sep 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
#3125
Also fixes #3043 by changing pragma usage
Description of changes:
How did you test these changes?
(Please add a line here how the changes were tested)
Documentation update required?
General Checklist
fix(storage): message,feat(auth): message,chore(all): message)By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.