Skip to content

chore: Remove inconsistent test #3131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 10, 2025
Merged

chore: Remove inconsistent test #3131

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5d29c83
Remove test that contains a race condition
mattcreaser Sep 9, 2025
fe4b795
Save test reports when tests fail
mattcreaser Sep 9, 2025
8c61c48
Merge branch 'main' into mattcreaser/test-stability
mattcreaser Sep 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions .github/workflows/codecov_code_coverage.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ on:
pull_request:
branches:
- 'main'
workflow_dispatch:

jobs:
build:
Expand All @@ -30,3 +31,11 @@ jobs:
name: report
files: build/reports/kover/report.xml
token: ${{ secrets.CODECOV_TOKEN }}

- name: Upload test reports
uses: actions/upload-artifact@ea165f8d65b6e75b540449e92b4886f43607fa02 # v4
if: failure()
with:
name: test-reports
path: '**/reports/tests/**'
retention-days: 7
19 changes: 0 additions & 19 deletions ...auth-cognito/src/test/java/com/amplifyframework/statemachine/StateMachineListenerTests.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,6 @@ import com.amplifyframework.statemachine.state.CounterStateMachine
import java.util.concurrent.CountDownLatch
import java.util.concurrent.TimeUnit
import kotlin.test.assertEquals
import kotlin.test.assertFalse
import kotlin.test.assertTrue
import kotlinx.coroutines.Dispatchers
import kotlinx.coroutines.newSingleThreadContext
Expand Down Expand Up @@ -128,22 +127,4 @@ class StateMachineListenerTests {
stateMachine.send(Counter.Event("2", eventType = Increment))
assertTrue { listenLatch.await(5, TimeUnit.SECONDS) }
}

@Test
fun testNoNotifyImmediateCancel() {
stateMachine.send(Counter.Event("1", eventType = Increment))
val listenLatch = CountDownLatch(1)
val token = StateChangeListenerToken()
stateMachine.listen(
token,
{
listenLatch.countDown()
},
null
)

stateMachine.cancel(token)
stateMachine.send(Counter.Event("2", eventType = Increment))
assertFalse { listenLatch.await(5, TimeUnit.SECONDS) }
}
}