fix(storage): Prevent missed transfer status updates#3154
Merged
tylerjroach merged 9 commits intomainfrom Nov 6, 2025
Merged
Conversation
added 3 commits
November 4, 2025 15:04
mattcreaser
previously approved these changes
Nov 5, 2025
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #3154 +/- ##
==========================================
+ Coverage 54.71% 54.74% +0.03%
==========================================
Files 1046 1046
Lines 31251 31255 +4
Branches 4690 4690
==========================================
+ Hits 17099 17111 +12
+ Misses 12328 12318 -10
- Partials 1824 1826 +2 🚀 New features to boost your workflow:
|
mattcreaser
approved these changes
Nov 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
#3150
Fix StoragePath uploads to non-default buckets not triggering onSuccess callbacks
Problem
StoragePath uploads to non-default buckets were not triggering
onSuccesscallbacks, while progress callbacks worked correctly and uploads to the default bucket succeeded.Root Cause
Multi-bucket support introduced multiple
AWSS3StorageServiceinstances (one per bucket), each creating its ownTransferManagerwith its ownTransferStatusUpdater. However, the singletonTransferWorkerObserveronly calls completion events on the firstTransferStatusUpdaterit encountered (from the default bucket).This created a mismatch:
TransferStatusUpdaterTransferWorkerObserversent events to the default bucket'sTransferStatusUpdateronSuccesscallbacks never triggered for non-default bucketsSolution
Implemented dependency injection to share a single
TransferStatusUpdateracross all storage services:TransferStatusUpdaterinstance during configurationHow did you test these changes?
(Please add a line here how the changes were tested)
Documentation update required?
General Checklist
fix(storage): message,feat(auth): message,chore(all): message)By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.