fix: resolve test errors and add a new test

aws-amplify · Apr 6, 2024 · 596c690 · 596c690
1 parent cd7d550
commit 596c690
Show file tree

Hide file tree

Showing 4 changed files with 7,444 additions and 7,612 deletions.
diff --git a/packages/amplify-opensearch-simulator/API.md b/packages/amplify-opensearch-simulator/API.md
@@ -4,8 +4,6 @@
 
 ```ts
 
-/// <reference types="node" />
-
 import { $TSAny } from '@aws-amplify/amplify-cli-core';
 import execa from 'execa';
 import { GetPackageAssetPaths } from '@aws-amplify/amplify-cli-core';

diff --git a/packages/amplify-util-mock/src/__tests__/api/api.test.ts b/packages/amplify-util-mock/src/__tests__/api/api.test.ts
@@ -135,6 +135,35 @@ describe('Test Mock API methods', () => {
     await expect(mockContext.print.error).toHaveBeenCalledWith('Failed to start API Mocking.');
   });
 
+  it('shows error message and resolution when https enabled if SSL key and certificate paths are not provided', async () => {
+    ConfigOverrideManager.getInstance = jest.fn().mockReturnValue(jest.fn);
+    const mockContext = {
+      print: {
+        red: jest.fn(),
+        green: jest.fn(),
+        error: jest.fn(),
+      },
+      parameters: {
+        options: {
+          help: false,
+        },
+      },
+      input: {
+        argv: ['--https'],
+      },
+      amplify: {
+        getEnvInfo: jest.fn().mockReturnValue({ projectPath: mockProjectRoot }),
+        pathManager: {
+          getGitIgnoreFilePath: jest.fn(),
+        },
+      },
+    } as unknown as $TSContext;
+    await run(mockContext);
+    await expect(mockContext.print.error).toHaveBeenCalledWith(
+      '\nThe --https option must be followed by the path to the SSL key and the path to the SSL certificate.\n',
+    );
+  });
+
   it('attempts to set custom port correctly', async () => {
     const GRAPHQL_PORT = 8081;
     const mockContext = {

diff --git a/packages/amplify-util-mock/src/utils/get-https-config.ts b/packages/amplify-util-mock/src/utils/get-https-config.ts
@@ -1,5 +1,10 @@
 export function getHttpsConfig(context): { sslKeyPath: string | undefined; sslCertPath: string | undefined } {
   const paths: { sslKeyPath: string | undefined; sslCertPath: string | undefined } = { sslKeyPath: undefined, sslCertPath: undefined };
+
+  if (!context.input || !context.input.argv) {
+    return paths;
+  }
+
   const argv = context.input.argv;
   const httpsIndex = argv.indexOf('--https');