Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: generate components using graphql #12973

Merged
merged 1 commit into from
Aug 10, 2023
Merged

Conversation

awinberg-aws
Copy link
Contributor

@awinberg-aws awinberg-aws commented Jul 19, 2023

Description of changes

Updates the UI Builder plugin to include configurations for what APIs should be used in a customer's codegen output.

Issue #, if available

Description of how you validated changes

Checklist

  • PR description included
  • yarn test passes
  • Tests are changed or added
  • Relevant documentation is changed or added (and PR referenced)
  • New AWS SDK calls or CloudFormation actions have been added to relevant test and service IAM policies
  • Pull request labels are added

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@awinberg-aws awinberg-aws force-pushed the feat/codegen-service-graphql branch 6 times, most recently from 742aa94 to 452f278 Compare July 31, 2023 23:23
@awinberg-aws awinberg-aws force-pushed the feat/codegen-service-graphql branch 3 times, most recently from 2ca8532 to af5ec90 Compare August 1, 2023 22:28
Jshhhh
Jshhhh previously approved these changes Aug 1, 2023
@awinberg-aws awinberg-aws marked this pull request as ready for review August 1, 2023 23:16
@awinberg-aws awinberg-aws requested a review from a team as a code owner August 1, 2023 23:16
rtpascual
rtpascual previously approved these changes Aug 2, 2023
@awinberg-aws awinberg-aws dismissed stale reviews from rtpascual and Jshhhh via 837112f August 2, 2023 23:21
@awinberg-aws awinberg-aws force-pushed the feat/codegen-service-graphql branch 2 times, most recently from 837112f to 203f11c Compare August 3, 2023 00:16
letsbelopez
letsbelopez previously approved these changes Aug 3, 2023
Copy link
Contributor

@letsbelopez letsbelopez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

rtpascual
rtpascual previously approved these changes Aug 3, 2023
jhockett
jhockett previously approved these changes Aug 4, 2023
jhockett
jhockett previously approved these changes Aug 4, 2023
rtpascual
rtpascual previously approved these changes Aug 5, 2023
sobolk
sobolk previously requested changes Aug 5, 2023
Copy link
Member

@sobolk sobolk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please hold with merge for a moment. We lost static analysis in our pipelines.

@sobolk sobolk dismissed their stale review August 5, 2023 01:08

Linter is back

@sobolk
Copy link
Member

sobolk commented Aug 5, 2023

Please hold with merge for a moment. We lost static analysis in our pipelines.

Static analysis is restored in pipelines, but has not run on this PR. @awinberg-aws before merging I recommend to either validate PR manually by running yarn lint-check or merge latest dev into PR to refresh pipeline definition.

@awinberg-aws
Copy link
Contributor Author

@sobolk I'll rebase and re-push

jhockett
jhockett previously approved these changes Aug 8, 2023
Milan-Shah
Milan-Shah previously approved these changes Aug 8, 2023
Milan-Shah
Milan-Shah previously approved these changes Aug 9, 2023
@Amplifiyer Amplifiyer merged commit 1d07ad8 into dev Aug 10, 2023
7 checks passed
@Amplifiyer Amplifiyer deleted the feat/codegen-service-graphql branch August 10, 2023 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants