Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: replace role mapping lambda in auth category #13003

Merged
merged 9 commits into from
Jul 26, 2023

Conversation

sobolk
Copy link
Member

@sobolk sobolk commented Jul 25, 2023

Description of changes

This PR:

Issue #, if available

Description of how you validated changes

E2E tests: https://app.circleci.com/pipelines/github/aws-amplify/amplify-cli?branch=run-e2e%2Fsobkamil%2Fuser-groups-lambda
Failed tests:

Checklist

  • PR description included
  • yarn test passes
  • Tests are changed or added
  • Relevant documentation is changed or added (and PR referenced)
  • New AWS SDK calls or CloudFormation actions have been added to relevant test and service IAM policies
  • Pull request labels are added

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@sobolk sobolk requested review from a team as code owners July 25, 2023 14:44
@sobolk sobolk changed the title feat: replace role mapping lambda in out category feat: replace role mapping lambda in auth category Jul 25, 2023
@codecov-commenter
Copy link

Codecov Report

Merging #13003 (32847a3) into dev (ec9a2ba) will increase coverage by 48.38%.
The diff coverage is 57.87%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@             Coverage Diff             @@
##              dev   #13003       +/-   ##
===========================================
+ Coverage    0.00%   48.38%   +48.38%     
===========================================
  Files        1296      840      -456     
  Lines      149743    38065   -111678     
  Branches     1296     7787     +6491     
===========================================
+ Hits            0    18417    +18417     
+ Misses     148447    18055   -130392     
- Partials     1296     1593      +297     
Files Changed Coverage Δ
...rmation/auth-stack-builder/auth-stack-transform.ts 89.22% <ø> (+89.22%) ⬆️
...tack-builder/auth-user-pool-group-stack-builder.ts 51.72% <ø> (+51.72%) ⬆️
.../src/provider-utils/awscloudformation/constants.ts 100.00% <ø> (+100.00%) ⬆️
...e-walkthrough-types/awsCognito-user-input-types.ts 100.00% <ø> (+100.00%) ⬆️
...vice-walkthrough-types/cognito-user-input-types.ts 100.00% <ø> (+100.00%) ⬆️
...y-category-function/src/commands/function/build.ts 0.00% <0.00%> (ø)
...ify-category-function/src/events/prePushHandler.ts 33.33% <0.00%> (+33.33%) ⬆️
...ider-utils/awscloudformation/utils/layerHelpers.ts 21.80% <0.00%> (+21.80%) ⬆️
...er-utils/awscloudformation/utils/storeResources.ts 30.38% <ø> (+30.38%) ⬆️
...ib/S3AndCloudFront/helpers/configure-CloudFront.js 87.06% <ø> (+87.06%) ⬆️
... and 60 more

... and 1236 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Amplifiyer
Amplifiyer previously approved these changes Jul 25, 2023
edwardfoyle
edwardfoyle previously approved these changes Jul 25, 2023
@sobolk sobolk dismissed stale reviews from edwardfoyle and Amplifiyer via 1d9f279 July 25, 2023 23:11
@sobolk sobolk merged commit 4ce0329 into aws-amplify:dev Jul 26, 2023
3 checks passed
@sobolk sobolk deleted the user-groups-lambda branch July 26, 2023 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants