-
Notifications
You must be signed in to change notification settings - Fork 820
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support https for mock util plugin #13700
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feat: add https option to mock api
… into dev-util-mock-pr1
sobolk
reviewed
Apr 19, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall this is looking good.
Please make sure that:
yarn lint-check
yarn prettier-check
are passing.
Hi @sobolk Thank you for the review. I updated the code and resolved the issues. Could you take a look? |
Amplifiyer
reviewed
Apr 24, 2024
Amplifiyer
approved these changes
Apr 24, 2024
sobolk
approved these changes
Apr 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will be make it possible to run mock server with HTTPS enabled. HTTPS support for local mock server ensures that we can accurately replicate secure environments during testing phase.
Description of changes
Added the HTTPS option to the
amplify mock
command. Updated Amplify Appsync Simulator to create a HTTPS server when the option is enabled.For example,
amplify mock api --https /path/to/key /path/to/cert
will run a local HTTPS server.Description of how you validated changes
Implemented additional tests.
Checklist
yarn test
passesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.